ShayanEdalatjoo/HW-04-JAVA-KNIGHT
1
1
Fork 0
forked from AdvancedProgramming1404/HW-04-JAVA-KNIGHT
Code Pull Requests 1 Activity

develop #1

Open
ShayanEdalatjoo wants to merge 3 commits from develop into main
pull from: develop
merge into: :main
Conversation 2 Commits 3 Files Changed 43
+708 -226
ShayanEdalatjoo commented 2026-05-13 09:58:46 +00:00
Owner
Copy Link
Copy Source
No description provided.
ShayanEdalatjoo added 2 commits 2026-05-13 09:58:46 +00:00
Releasing version one. 2ec3641f00
Cleaning comments. 2fd072057a
ShayanEdalatjoo requested review from HoseinA05 2026-05-13 09:58:46 +00:00
HoseinA05 requested changes 2026-07-02 16:53:05 +00:00
Dismissed
HoseinA05 left a comment
Collaborator
Copy Link
Copy Source

Grades:
Main: 410/500
Bonus: 0/100

Main:

  • No comments/documentation
  • No readme
  • Missing gaurd + special Attack moves
  • No XP/leveling
  • No key collection

Recommendation:

  • remove .class files (update .gitignore)
Grades: Main: 410/500 Bonus: 0/100 Main: - No comments/documentation - No readme - Missing gaurd + special Attack moves - No XP/leveling - No key collection --- Recommendation: - remove .class files (update .gitignore)
ShayanEdalatjoo added 1 commit 2026-07-17 20:28:11 +00:00
Changing readme.md d25378c453
ShayanEdalatjoo requested review from HoseinA05 2026-07-17 20:28:16 +00:00
HoseinA05 requested changes 2026-07-30 13:55:55 +00:00
HoseinA05 left a comment
Collaborator
Copy Link
Copy Source

Readme got better, but there are still other issues mentioned

Main: 425/500

Readme got better, but there are still other issues mentioned Main: 425/500
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin develop:develop
git checkout develop
Sign in to join this conversation.
Reviewers
No Reviewers
HoseinA05
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
HoseinA05 (Hosein Asfiaee) ShayanEdalatjoo
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ShayanEdalatjoo/HW-04-JAVA-KNIGHT#1