RezaK/HW-10-Socket-Programming-T
1
0
Fork 0
forked from AdvancedProgramming1404/HW-10-Socket-Programming
Code Pull Requests 1 Activity

complete #1

Open
RezaK wants to merge 1 commits from develop into main
pull from: develop
merge into: :main
Conversation 1 Commits 1 Files Changed 4
+192 -66
RezaK commented 2026-06-19 10:16:47 +00:00
Owner
Copy Link
Copy Source
No description provided.
RezaK added 1 commit 2026-06-19 10:16:48 +00:00
complete d6b7215667
RezaK requested review from HoseinA05 2026-06-19 10:16:48 +00:00
HoseinA05 approved these changes 2026-07-03 08:41:59 +00:00
HoseinA05 left a comment
Collaborator
Copy Link
Copy Source

Good!

Grades:
Main: 500/500
Bonus: 0/300

Recommendation:

  • check for login success from server too. (you are only checking failed login)
Good! Grades: Main: 500/500 Bonus: 0/300 Recommendation: - check for login success from server too. (you are only checking failed login)
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin develop:develop
git checkout develop
Sign in to join this conversation.
Reviewers
No Reviewers
HoseinA05
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
HoseinA05 (Hosein Asfiaee) RezaK
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RezaK/HW-10-Socket-Programming-T#1