RezaK/HW-04-JAVA-KNIGHT-T
1
1
Fork 0
forked from AdvancedProgramming1404/HW-04-JAVA-KNIGHT
Code Pull Requests 1 Activity

develop #1

Open
RezaK wants to merge 3 commits from develop into main
pull from: develop
merge into: :main
Conversation 1 Commits 3 Files Changed 50
+1007 -306
RezaK commented 2026-05-10 19:29:45 +00:00
Owner
Copy Link
Copy Source
No description provided.
RezaK added 3 commits 2026-05-10 19:29:46 +00:00
complete 74661a417d
complete 5a412956ce
complete 31ddda225b
RezaK requested review from HoseinA05 2026-05-10 19:29:46 +00:00
HoseinA05 approved these changes 2026-07-02 16:26:09 +00:00
HoseinA05 left a comment
Collaborator
Copy Link
Copy Source

Good!

Grades:
Main: 490/500
Bonus: 40/100

Main:

  • No comments/documentation!

Bonus:

  • 1, 2 implemented, but inventory is just flasks, there is no way to swap items!

Recommendations:

  • use some meaningful massages to tell player what's happening (like when Knight doesn't take damage, tell it's because of armor, or other things)
  • remove .class files (update .gitignore)
Good! Grades: Main: 490/500 Bonus: 40/100 Main: - No comments/documentation! Bonus: - 1, 2 implemented, but inventory is just flasks, there is no way to swap items! --- Recommendations: - use some meaningful massages to tell player what's happening (like when Knight doesn't take damage, tell it's because of armor, or other things) - remove .class files (update .gitignore)
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin develop:develop
git checkout develop
Sign in to join this conversation.
Reviewers
No Reviewers
HoseinA05
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
HoseinA05 (Hosein Asfiaee) RezaK
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RezaK/HW-04-JAVA-KNIGHT-T#1